Web Developer / Software Engineer
Hyogo, Japan


  • prebid/Prebid.js

    Adagio Adapter: set back to the original style after getSlotPosition

    Type of change Bugfix Description of change The Adagio adapter revert to the previous style of the element itself, rather than computed style. Details is the issue #9035. Resolves #9035 Other information

    pokutuna opened on 2022-09-25
  • prebid/Prebid.js

    Adagio Adapter: getSlotPosition breaks ad slot styles

    Type of issue Bug Description Since adding the Adagio adapter, I have found that some ad slots remain hidden. Adagio adapter sends adunit_position which means slot position from window.top with bid request. Adagio adapter temporarily set display: block to the slot element to compute its position, and then reverts to the previous computed style. Prebid.js/modules/adagioBidAdapter.js Lines 791 to 800 in 0acda04 const elComputedStyle = wt.getComputedStyle(domElement, null); const elComputedDisplay = elComputedStyle.display || 'block'; const mustDisplayElement = elComputedDisplay === 'none'; if (mustDisplayElement) { domElement.style = domElement.style || {}; domElement.style.display = 'block'; box = domElement.getBoundingClientRect(); domElement.style.display = elComputedDisplay; } This moves the style from the stylesheet to the elements and away from the control of the website to switch classes. This causes problems when ad slots have placed that switch between display states. For example, when a ad slot is placed in a collapsible sidebar or when content and an ad slot are switched by some condition. In this situation, the ad slot itself or the page part containing the ad slot may have display: none at bidding time and continue to retain the style by Adagio adapter. To avoid this problem, the adapter should revert to the previous style of the element itself, rather than computed style. Steps to reproduce Occurs when SafeFrame is not used and window.top is accessible. Prebid.js/modules/adagioBidAdapter.js Line 763 in 0acda04 } else if (canAccessTopWindow()) { 1. Starts with hidden ad slots <style> .is-hidden { display: none; } </style> <div id="slot1" class="is-hidden"></div> <div id="container" class="is-hidden"> <div id="slot2"></div> </div> 2. Adapter calculates slot positions <style> .is-hidden { display: none; } </style> <div id="slot1" class="is-hidden" style="display: block;"></div> <div id="container" class="is-hidden"> <div id="slot2" style="display: block;"></div> </div> 3. Adapter reverts styles to computed <style> .is-hidden { display: none; } </style> <div id="slot1" class="is-hidden" style="display: none;"></div> <div id="container" class="is-hidden"> <div id="slot2" style="display: none;"></div> </div> 4. Publisher site attempts to display by removing class <style> .is-hidden { display: none; } </style> <div id="slot1" class="" style="display: none;"></div> <div id="container" class=""> <div id="slot2" style="display: none;"></div> </div> Test page Expected results Actual results Platform details Other information When working with Google Ad Manager, gpt.js (pubads_impl_*.js) may eventually work correctly by updating the styles of elements (removing display: none for ad slot). However, problems occur when using other ad servers. It is better not to depend on the gpt.js behavior. And the fix is easy.

    pokutuna opened on 2022-09-25
  • genkiroid/cert

    Update install command

    Fixed installation commands in README. Installation executables by go get is deprecated in 1.17. https://go.dev/doc/go1.17#go-get no longer works in 1.18 https://go.dev/doc/go1.18#go-get Installation by go install is available from 1.16 (released 2021-02-16). It seems recent, but 1.16 is no longer supported.

    pokutuna opened on 2022-04-25
  • techtouch-inc/Go-SCP-jaJP

    fix: fix typo 切り捨てい → 切り捨て

    原文: https://github.com/OWASP/Go-SCP/blob/248f41d62b7cd17c0ea4f140546fe8888472ece1/src/input-validation/validation.md?plain=1#L138L139

    pokutuna opened on 2022-08-27
  • google/gts

    How about providing a tagged package refers to the head

    Hello, I love this gts project and use this in many projects. This makes me free from chores. But the release cycles are not so fast beside other typescript ecosystems. I’m always waiting to be released this when new typescript is released. I understand that gts is used in many google typescript projects, but I want to use gts and the latest typescript. How about providing a tagged package refers to the head of the master? Something like gts@head or gts@beta are published when CI passed on the master. As another solution, I can depend on gts as git+https://github.com/google/gts, but it doesn't work and I fixed it (#553). But it's better to be provided as a built package.

    pokutuna opened on 2020-08-25
  • GoogleCloudPlatform/cloud-run-button

    remove a TODO, --use-http2 is GA

    http2 is went GA on 2021-06-22 https://cloud.google.com/run/docs/release-notes#June_22_2021 Just to make sure, I've check gcloud version on Cloud Shell Editor, Google Cloud SDK is 386.0.0 and gcloud run deploy --help includes --[no-]use-http2 option.

    pokutuna opened on 2022-06-05
  • GoogleCloudPlatform/bigquery-utils

    Create bqutil UDFs in all other non-US datasets

    I ran into some issues when trying to use CTE's in combination with bqutil. This exectues as expected: SELECT `bqutil.fn.median`([1,1,1,2,3,4,5,100,1000]) as median However, after adding a CTE: WITH covid AS ( SELECT date, daily_confirmed_cases FROM `bigquery-public-data.covid19_ecdc_eu.covid_19_geographic_distribution_worldwide` ) SELECT `bqutil.fn.median`([1,1,1,2,3,4,5,100,1000]) as median BQ throws the error: "Function not found: bqutil.fn.median". I there a way to explicitly import the BQ utils or any other suggestions to address this issue?

    davidvanrooij opened on 2021-07-06
  • golang/appengine

    Fix header name to associate log entry & trace

    Thanks for releasing v2. I tried the log API on GAE 2nd gen, but it didn't associate with the request log. The request header to get a trace id and a span id is correct X-Cloud-Trace-Context, not Cloud-Trace-Context.

    pokutuna opened on 2021-09-29
  • terraform-google-modules/terraform-google-github-actions-runners

    fix: bump minimum provider version for gh oidc module

    Version 3.53 fails to set member starting with "principalSet" in google_service_account_iam_member. terraform-google-github-actions-runners/modules/gh-oidc/main.tf Line 45 in 138c753 member = "principalSet://iam.googleapis.com/${google_iam_workload_identity_pool.main.name}/${each.value.attribute}" This issue has reported this problem. hashicorp/terraform-provider-google#7852 And terraform-provider-google fixed this on 3.64. https://github.com/hashicorp/terraform-provider-google/releases/tag/v3.64.0 I've confirmed that ghe_oidc module fails with v3.63 and succeeds with v3.64.

    pokutuna opened on 2021-11-25
  • terraform-google-modules/terraform-google-github-actions-runners

    docs: fix sa_name example & description

    Sorry for my trivial PR again. sa_name in gh-oidc module doesn't expect an email address of service accounts. It passes to google_service_account_iam_member, which is a resource name like projects/{project_id}/serviceAccounts/{email}.

    pokutuna opened on 2021-11-25